Drop Python 3.9 support #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjeffery
force-pushed
the
drop3.9
branch
2 times, most recently
from
010de2d to
685f821
Compare
|
Looks like |
|
I'd like to turn off as much of the Ruff stuff as we can. There's a difference between not supporting an old version and gratuitously breaking the code on old versions for the sake of making something that's of limited value (type annotations; IMO) slightly nicer looking. |
|
Maybe that's not feasible - let's not worry too much about it. I do resent the time spent on managing type annotations... |
|
Looks like this pulled in some tskit stuff? |
|
I've moved the pin to the |
jeromekelleher
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent dependancy updates (specifically
clickas shown in #374) are no longer supporting 3.9. To avoid pinning or writing code to deal with multipleclickversions, it is probably time to drop 3.9.